Skip to content

[Metricbeat] Create elb metricset using light weight module#12952

Merged
kaiyan-sheng merged 14 commits intoelastic:masterfrom
kaiyan-sheng:add_elb
Aug 5, 2019
Merged

[Metricbeat] Create elb metricset using light weight module#12952
kaiyan-sheng merged 14 commits intoelastic:masterfrom
kaiyan-sheng:add_elb

Conversation

@kaiyan-sheng
Copy link
Copy Markdown
Contributor

@kaiyan-sheng kaiyan-sheng commented Jul 17, 2019 •
edited
Loading

This PR is to use #12465 to create elb metricset for aws. elb metricset collects metrics from aws cloudwatch with namespace AWS/ELB using aws module cloudwatch metricset.

There is also a pre defined dashboard added in this PR:
Screen Shot 2019-08-01 at 11 08 42 AM

closes #11701

How to test this:

  1. Make sure the AWS environment you are using for testing has ELB, which is a part of EC2. So to check if your environment has load balancers, go to EC2 service and then click Load Balancers on the left side: https://console.aws.amazon.com/ec2/v2/home?region=us-east-1#LoadBalancers:
  2. Make sure AWS credentials are correct and valid in ~/.aws/credentials under profile test-mb
  3. Download Metricbeat and enable aws module: ./metricbeat modules enable aws
  4. Change aws.yml to enable elb metricset:
- module: aws
  period: 300s
  credential_profile_name: test-mb
  metricsets:
    - elb
  1. Check Kibana dashboard or Discover for elb data

@kaiyan-sheng kaiyan-sheng requested review from a team as code owners July 17, 2019 18:20
@kaiyan-sheng kaiyan-sheng self-assigned this Jul 17, 2019
@kaiyan-sheng kaiyan-sheng added Team:Integrations Label for the Integrations team Metricbeat Metricbeat in progress Pull request is currently in progress. [zube]: In Progress labels Jul 17, 2019
jsoriano
jsoriano reviewed Jul 18, 2019
View reviewed changes
Comment thread metricbeat/docs/modules/cockroachdb/status.asciidoc Outdated
Comment thread x-pack/metricbeat/magefile.go Outdated
Comment thread x-pack/metricbeat/module/aws/elb/_meta/data.json Outdated
Comment thread x-pack/metricbeat/module/aws/elb/elb.go Outdated
Comment thread x-pack/metricbeat/module/aws/elb/elb_integration_test.go Outdated
Comment thread x-pack/metricbeat/module/aws/module.yml Outdated
Comment thread x-pack/metricbeat/include/list.go Outdated
jsoriano
jsoriano reviewed Jul 19, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@jsoriano jsoriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good, are you planning to create a dashboard? 🙂

@kaiyan-sheng
Copy link
Copy Markdown
Contributor Author

kaiyan-sheng commented Jul 19, 2019

This is looking good, are you planning to create a dashboard? 🙂

@jsoriano Yes, after adding a dashboard I will make this PR in review (officially 😬)!

jsoriano
jsoriano reviewed Jul 31, 2019
View reviewed changes
Comment thread x-pack/metricbeat/module/aws/elb/_meta/data.json Outdated
exekias
exekias reviewed Jul 31, 2019
View reviewed changes
Comment thread x-pack/metricbeat/module/aws/elb/_meta/data.json Outdated
exekias
exekias reviewed Jul 31, 2019
View reviewed changes
Comment thread x-pack/metricbeat/module/aws/elb/manifest.yml Outdated
@kaiyan-sheng kaiyan-sheng added [zube]: In Review review and removed [zube]: In Progress in progress Pull request is currently in progress. labels Aug 1, 2019
@kaiyan-sheng
Copy link
Copy Markdown
Contributor Author

kaiyan-sheng commented Aug 1, 2019

@jsoriano I added a dashboard for ELB and moved this PR to in review. I waited for a while to try to get better looking data but so far no luck by using the test aws env 😬

jsoriano
jsoriano reviewed Aug 2, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@jsoriano jsoriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice dashboard! Just one detail.

Comment thread x-pack/metricbeat/module/aws/_meta/kibana/7/dashboard/Metricbeat-aws-elb-overview.json Outdated
@kaiyan-sheng kaiyan-sheng merged commit 1c96bf3 into elastic:master Aug 5, 2019
@kaiyan-sheng kaiyan-sheng deleted the add_elb branch August 5, 2019 13:02
@kaiyan-sheng kaiyan-sheng added the test-plan Add this PR to be manual test plan label Aug 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jsoriano jsoriano jsoriano approved these changes

+1 more reviewer

@exekias exekias exekias left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@kaiyan-sheng kaiyan-sheng

Labels

Metricbeat Metricbeat review Team:Integrations Label for the Integrations team test-plan Add this PR to be manual test plan v7.4.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Metricbeat] Adding AWS ELB Metricset

4 participants

@kaiyan-sheng @jsoriano @exekias @andresrc